maskit commented on a change in pull request #8612:
URL: https://github.com/apache/trafficserver/pull/8612#discussion_r786564686
##########
File path: proxy/http/HttpSM.cc
##########
@@ -655,16 +655,16 @@ HttpSM::setup_blind_tunnel_port()
u.scheme_set(URL_SCHEME_TUNNEL, URL_LEN_TUNNEL);
t_state.hdr_info.client_request.url_set(&u);
- if (ssl_vc->has_tunnel_destination()) {
- const char *tunnel_host = ssl_vc->get_tunnel_host();
+ if (tts->has_tunnel_destination()) {
+ const char *tunnel_host = tts->get_tunnel_host();
t_state.hdr_info.client_request.url_get()->host_set(tunnel_host,
strlen(tunnel_host));
- if (ssl_vc->get_tunnel_port() > 0) {
-
t_state.hdr_info.client_request.url_get()->port_set(ssl_vc->get_tunnel_port());
+ if (tts->get_tunnel_port() > 0) {
+
t_state.hdr_info.client_request.url_get()->port_set(tts->get_tunnel_port());
} else {
t_state.hdr_info.client_request.url_get()->port_set(netvc->get_local_port());
}
} else {
-
t_state.hdr_info.client_request.url_get()->host_set(ssl_vc->get_server_name(),
strlen(ssl_vc->get_server_name()));
+
t_state.hdr_info.client_request.url_get()->host_set(netvc->get_server_name(),
strlen(netvc->get_server_name()));
Review comment:
I don't think we need to use `ssl_vc` because `get_server_name` is a
virtual function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
