ywkaras commented on a change in pull request #8636:
URL: https://github.com/apache/trafficserver/pull/8636#discussion_r797971452
##########
File path: include/tscpp/util/TsSharedMutex.h
##########
@@ -53,6 +54,30 @@
namespace ts
{
+class Strerror
+{
+public:
+ Strerror(int err_num)
+ {
+ _c_str = strerror_r(err_num, _buf, 256);
+ if (!_c_str) {
Review comment:
TS is compiled with -D_GNU_SOURCE, which means that only the
GNU-specific strerror_r() is available. Even if it never returns null
(currently), I'd rather leave the handling in for future-safety.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]