AD5GB commented on pull request #8680: URL: https://github.com/apache/trafficserver/pull/8680#issuecomment-1045902007
Well, you *could* make Clang-xx a requirement; all other toolchains unsupported 😉. I wonder then if the #include should be conditional somehow then. My personal preference is to *not* have code littered with a large amount of #ifdef/#ifndef #endif statements but depending on project goals it sometimes becomes necessary. I'm actually grappling with some of this trying to get it to build on OmniOS. I'm looking into GNU configure tools for a lot of that though as I really haven't worked much with them. Anyway, thanks for all that you do! On 2/18/2022 5:18 PM, Brian Neradt wrote: > > ***@***.**** approved this pull request. > > Thanks for the fix. > > I'm updating CI to use gcc-11 to catch these during the PR checks. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/trafficserver/pull/8680#pullrequestreview-887831575>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ABHLI3ZF73VBVEFCHX5LEJLU33HSZANCNFSM5OZGSLNA>. > Triage notifications on the go with GitHub Mobile for iOS > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> > or Android > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > > You are receiving this because you were assigned.Message ID: > ***@***.***> > -- Randall DuCharme (Radio AD5GB) Powered entirely by Open Source software. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
