cmcfarlen commented on a change in pull request #8716:
URL: https://github.com/apache/trafficserver/pull/8716#discussion_r821219612
##########
File path: iocore/cache/P_CacheVol.h
##########
@@ -206,6 +206,12 @@ struct Vol : public Continuation {
int dir_check(bool fix);
int db_check(bool fix);
+ bool
+ evac_bucket_valid(off_t bucket)
+ {
+ return (bucket >= 0 && bucket < evacuate_size);
Review comment:
The macro `dir_evac_bucket` produces a `long long` and seem to be stored
as `off_t` in other places in the code so I thought it might be a reasonable
type for the argument here. `off_t` is a signed type so I check for >= 0.
Ideally the macro would return an unsigned bucket, but I'm not sure the
implication of that change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
