ywkaras commented on a change in pull request #8689:
URL: https://github.com/apache/trafficserver/pull/8689#discussion_r827402854
##########
File path: proxy/HostStatus.h
##########
@@ -182,11 +218,16 @@ struct HostStatus {
}
void setHostStatus(const std::string_view name, const TSHostStatus status,
const unsigned int down_time,
const unsigned int reason);
- HostStatRec *getHostStatus(const std::string_view name);
- void createHostStat(const std::string_view name, const char *data = nullptr);
- void loadHostStatusFromStats();
+ void loadFromPersistentStore();
void loadRecord(std::string_view name, HostStatRec &h);
- RecErrT getHostStat(std::string &stat_name, char *buf, unsigned int buf_len);
+ HostStatRec *getHostStatus(const std::string_view name);
+ void getAllHostStatuses(std::vector<HostStatuses> &hosts);
Review comment:
We should let the people who went to grad school tell us if it's wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]