ywkaras commented on a change in pull request #8743:
URL: https://github.com/apache/trafficserver/pull/8743#discussion_r832476747



##########
File path: plugins/lua/ts_lua_http_config.c
##########
@@ -293,7 +293,8 @@ ts_lua_var_item ts_lua_http_config_vars[] = {
 
 // Needed to make sure we have the latest list of overridable http config vars 
when compiling
 #define NUM_HTTP_CONFIG_VARS (sizeof(ts_lua_http_config_vars) / 
sizeof(ts_lua_http_config_vars[0]))
-extern char __ts_lua_http_config_vars_static_assert[NUM_HTTP_CONFIG_VARS == 
TS_CONFIG_LAST_ENTRY + 1 ? 0 : -1];
+// extern char __ts_lua_http_config_vars_static_assert[NUM_HTTP_CONFIG_VARS == 
TS_CONFIG_LAST_ENTRY + 1 ? 0 : -1];

Review comment:
       I also vote no commented out code.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to