masaori335 commented on code in PR #8976:
URL: https://github.com/apache/trafficserver/pull/8976#discussion_r929380442
##########
iocore/cache/CacheRead.cc:
##########
@@ -1173,6 +1173,20 @@ CacheVC::openReadStartHead(int event, Event *e)
} else {
f.single_fragment = false;
}
+
+ // Now that we have selected an alternate, validate that the content
length and object size match
+ MIMEField *field =
alternate.response_get()->field_find(MIME_FIELD_CONTENT_LENGTH,
MIME_LEN_CONTENT_LENGTH);
+ if (field) {
+ int64_t cl = field->value_get_int64();
Review Comment:
```
CacheRead.cc: In member function 'int CacheVC::openReadStartHead(int,
Event*)':
CacheRead.cc:1181:16: error: comparison of integer expressions of different
signedness: 'int64_t' {aka 'long int'} and 'uint64_t' {aka 'long unsigned int'}
[-Werror=sign-compare]
1181 | if (cl != doc_len) {
| ~~~^~~~~~~~~~
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
