maskit commented on code in PR #8972:
URL: https://github.com/apache/trafficserver/pull/8972#discussion_r939780333
##########
doc/admin-guide/files/records.config.en.rst:
##########
@@ -3956,6 +3956,12 @@ Client-Related Configuration
Enables (``1``) or disables (``0``) TLSv1_3 in the ATS client context. If
not specified, enabled by default
+.. ts:cv:: CONFIG proxy.config.ssl.client.alpn_protocols STRING ""
Review Comment:
Thanks for updating the documentation. At minimum it works for me, but I
can't tell if users want to read the external documents. The example
configurations are nice. I guess most users would just see the examples, and
copy a setting value from there. In that sense, whether name or ID is not
really important, although I think using names (or aliases) requires less
knowledge.
I'm not going to judge if the setting format is user friendly, but if I made
a Web UI for a CDN service that uses ATS, it'd have a reorderable list for this
setting and the items would have protocol names but not IDs. It wouldn't even
tell it's a setting for ALPN.
And very strictly speaking, "," is a valid character for an ALPN protocol
ID. I hope future protocol IDs (which we want to support) won't use it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
