maskit commented on code in PR #8963:
URL: https://github.com/apache/trafficserver/pull/8963#discussion_r940977582
##########
proxy/http2/HTTP2.cc:
##########
@@ -599,6 +610,9 @@ http2_convert_header_from_1_1_to_2(HTTPHdr *headers)
} else {
field->value_set(headers->m_heap, headers->m_mime, value, value_len);
}
+ // Remove the host header field, redundant to the authority field
+ // For istio/envoy, having both was causing 404 responses
Review Comment:
I found a TODO comment at right after your changes (on line 651). We can
remove the comment.
Also, I finished reviewing changes in `http2_convert_header_from_2_to_1_1`
and `http2_convert_header_from_1_1_to_2`. No additional change is needed except
the TODO comment I mentioned above. If you make a separate PR for these
changes, I can approve it immediately.
I'd say we can make the changes on master. Since we both modified the
functions and my change is going to be on master, that would be easier to
manage than having two different changes on master and 10-Dev.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
