bneradt commented on code in PR #9136:
URL: https://github.com/apache/trafficserver/pull/9136#discussion_r993606693
##########
tests/gold_tests/h2/http2_flow_control.test.py:
##########
@@ -107,7 +107,7 @@ def _configure_trafficserver(self):
'proxy.config.ssl.server.private_key.path':
f'{ts.Variables.SSLDir}',
'proxy.config.ssl.client.verify.server.policy': 'PERMISSIVE',
'proxy.config.dns.nameservers':
'127.0.0.1:{0}'.format(self._dns.Variables.Port),
- 'proxy.config.ssl.keylog_file': os.path.join(Test.RunDirectory,
'tls_session_keys.txt'),
+ 'proxy.config.ssl.keylog_file': '/tmp/tls_session_keys.txt',
Review Comment:
After thinking about the problem you faced some, I think it could be helpful
to just have the extension create the keylog file for all TLS traffic in a
consistent way. This will avoid the situation where test writers choose random
locations for the keylog file (like I've clearly done so far) and sometimes
choosing a location which doesn't work in some CI environments. What do you
think of this?
https://github.com/apache/trafficserver/pull/9137
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
