cmcfarlen commented on code in PR #9138:
URL: https://github.com/apache/trafficserver/pull/9138#discussion_r994021680


##########
plugins/experimental/maxmind_acl/mmdb.cc:
##########
@@ -670,7 +682,7 @@ Acl::eval_anonymous(MMDB_entry_s *entry)
 // allowable country code from our map.
 // False otherwise
 bool
-Acl::eval_country(MMDB_entry_data_s *entry_data, const char *path, int 
path_len)
+Acl::eval_country(MMDB_entry_data_s *entry_data, std::string url)

Review Comment:
   `const std::string&` here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to