bneradt commented on code in PR #9150:
URL: https://github.com/apache/trafficserver/pull/9150#discussion_r997597611
##########
proxy/http/HttpSM.cc:
##########
@@ -651,17 +651,22 @@ HttpSM::setup_blind_tunnel_port()
NetVConnection *netvc = ua_txn->get_netvc();
ink_release_assert(netvc);
int host_len;
- if (auto *tts = dynamic_cast<TLSTunnelSupport *>(netvc)) {
- if (!t_state.hdr_info.client_request.url_get()->host_get(&host_len)) {
- // the URL object has not been created in the start of the transaction.
Hence, we need to create the URL here
- URL u;
- t_state.hdr_info.client_request.create(HTTP_TYPE_REQUEST);
- t_state.hdr_info.client_request.method_set(HTTP_METHOD_CONNECT,
HTTP_LEN_CONNECT);
- t_state.hdr_info.client_request.url_create(&u);
- u.scheme_set(URL_SCHEME_TUNNEL, URL_LEN_TUNNEL);
- t_state.hdr_info.client_request.url_set(&u);
+ // This applies to both the TLS and non TLS cases
+ if (!t_state.hdr_info.client_request.url_get()->host_get(&host_len)) {
+ // the URL object has not been created in the start of the transaction.
Hence, we need to create the URL here
+ URL u;
+
+ t_state.hdr_info.client_request.create(HTTP_TYPE_REQUEST);
+ t_state.hdr_info.client_request.method_set(HTTP_METHOD_CONNECT,
HTTP_LEN_CONNECT);
+ t_state.hdr_info.client_request.url_create(&u);
+ u.scheme_set(URL_SCHEME_TUNNEL, URL_LEN_TUNNEL);
+ t_state.hdr_info.client_request.url_set(&u);
+ }
+ TLSTunnelSupport *tts = nullptr;
+ if (!ua_txn->is_outbound_transparent() && (tts =
dynamic_cast<TLSTunnelSupport *>(netvc))) {
+ if (!t_state.hdr_info.client_request.url_get()->host_get(&host_len)) {
Review Comment:
Probably good to combine these into one condition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
