duke8253 commented on code in PR #9141:
URL: https://github.com/apache/trafficserver/pull/9141#discussion_r1001138145
##########
build/jemalloc.m4:
##########
@@ -58,7 +58,7 @@ if test "$has_jemalloc" != "no"; then
if test "$jemalloc_base_dir" != "/usr"; then
TS_ADDTO(CPPFLAGS, [-I${jemalloc_include}])
TS_ADDTO(LDFLAGS, [-L${jemalloc_ldflags}])
- TS_ADDTO(LDFLAGS, [-Wl,--add-needed -L${jemalloc_ldflags}
-Wl,-rpath,${jemalloc_ldflags} -Wl,--no-as-needed])
Review Comment:
I don't think it's a typo because I remember coming back to this and thought
it was a typo, but changing it broke stuff. Though I can't remember exactly
what was it now, vaguely recall that something about the order of specifying
those options made a difference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]