ywkaras commented on PR #9183:
URL: https://github.com/apache/trafficserver/pull/9183#issuecomment-1306410061

   Fixes these two warnings:
   ```
   ==================
   WARNING: ThreadSanitizer: data race (pid=32645)
     Write of size 4 at 0x7f35405bc780 by thread T3:
       #0 freelist_new /home/wkaras/REPOS/TS/src/tscore/ink_queue.cc:251 
(libtscore.so.10+0x1938e6)
       #1 ink_freelist_new /home/wkaras/REPOS/TS/src/tscore/ink_queue.cc:187 
(libtscore.so.10+0x193341)
       #2 FreelistAllocator::alloc_void() ../../include/tscore/Allocator.h:63 
(traffic_server+0x7107ef)
       #3 Event* ClassAllocator<Event, false>::alloc<>() 
../../include/tscore/Allocator.h:241 (traffic_server+0x71631a)
       #4 EventProcessor::initThreadState(EThread*) 
/home/wkaras/REPOS/TS/iocore/eventsystem/UnixEventProcessor.cc:457 
(traffic_server+0xcf6ba4)
       #5 EventProcessor::ThreadInit::init(int, Event*) 
/home/wkaras/REPOS/TS/iocore/eventsystem/I_EventProcessor.h:388 
(traffic_server+0xcf7a76)
       #6 Continuation::handleEvent(int, void*) 
/home/wkaras/REPOS/TS/iocore/eventsystem/I_Continuation.h:227 
(traffic_server+0x711d65)
       #7 EThread::execute() 
/home/wkaras/REPOS/TS/iocore/eventsystem/UnixEThread.cc:333 
(traffic_server+0xcf290b)
       #8 spawn_thread_internal 
/home/wkaras/REPOS/TS/iocore/eventsystem/Thread.cc:79 (traffic_server+0xcf0278)
   
     Previous write of size 4 at 0x7f35405bc780 by thread T2:
       #0 freelist_new /home/wkaras/REPOS/TS/src/tscore/ink_queue.cc:251 
(libtscore.so.10+0x1938e6)
       #1 ink_freelist_new /home/wkaras/REPOS/TS/src/tscore/ink_queue.cc:187 
(libtscore.so.10+0x193341)
       #2 FreelistAllocator::alloc_void() ../../include/tscore/Allocator.h:63 
(traffic_server+0x7107ef)
       #3 Event* ClassAllocator<Event, false>::alloc<>() 
../../include/tscore/Allocator.h:241 (traffic_server+0x71631a)
       #4 EventProcessor::initThreadState(EThread*) 
/home/wkaras/REPOS/TS/iocore/eventsystem/UnixEventProcessor.cc:457 
(traffic_server+0xcf6ba4)
       #5 EventProcessor::ThreadInit::init(int, Event*) 
/home/wkaras/REPOS/TS/iocore/eventsystem/I_EventProcessor.h:388 
(traffic_server+0xcf7a76)
       #6 Continuation::handleEvent(int, void*) 
/home/wkaras/REPOS/TS/iocore/eventsystem/I_Continuation.h:227 
(traffic_server+0x711d65)
       #7 EThread::execute() 
/home/wkaras/REPOS/TS/iocore/eventsystem/UnixEThread.cc:333 
(traffic_server+0xcf290b)
       #8 spawn_thread_internal 
/home/wkaras/REPOS/TS/iocore/eventsystem/Thread.cc:79 (traffic_server+0xcf0278)
   
     Location is global 'fake_global_for_ink_queue' of size 4 at 0x7f35405bc780 
(libtscore.so.10+0x0000004aa780)
   
     Thread T3 '[ET_NET 1]' (tid=32656, running) created by main thread at:
       #0 pthread_create <null> (libtsan.so.0+0x615d8)
       #1 ink_thread_create ../../include/tscore/ink_thread.h:137 
(traffic_server+0xcefc7b)
       #2 Thread::start(char const*, void*, unsigned long, std::function<void 
()> const&) /home/wkaras/REPOS/TS/iocore/eventsystem/Thread.cc:96 
(traffic_server+0xcf03a6)
       #3 EventProcessor::spawn_event_threads(int, int, unsigned long) 
/home/wkaras/REPOS/TS/iocore/eventsystem/UnixEventProcessor.cc:439 
(traffic_server+0xcf68c1)
       #4 EventProcessor::start(int, unsigned long) 
/home/wkaras/REPOS/TS/iocore/eventsystem/UnixEventProcessor.cc:502 
(traffic_server+0xcf6f6c)
       #5 main traffic_server/traffic_server.cc:2025 (traffic_server+0x77f23a)
   
     Thread T2 '[ET_NET 0]' (tid=32655, running) created by main thread at:
       #0 pthread_create <null> (libtsan.so.0+0x615d8)
       #1 ink_thread_create ../../include/tscore/ink_thread.h:137 
(traffic_server+0xcefc7b)
       #2 Thread::start(char const*, void*, unsigned long, std::function<void 
()> const&) /home/wkaras/REPOS/TS/iocore/eventsystem/Thread.cc:96 
(traffic_server+0xcf03a6)
       #3 EventProcessor::spawn_event_threads(int, int, unsigned long) 
/home/wkaras/REPOS/TS/iocore/eventsystem/UnixEventProcessor.cc:439 
(traffic_server+0xcf68c1)
       #4 EventProcessor::start(int, unsigned long) 
/home/wkaras/REPOS/TS/iocore/eventsystem/UnixEventProcessor.cc:502 
(traffic_server+0xcf6f6c)
       #5 main traffic_server/traffic_server.cc:2025 (traffic_server+0x77f23a)
   
   SUMMARY: ThreadSanitizer: data race 
/home/wkaras/REPOS/TS/src/tscore/ink_queue.cc:251 in freelist_new
   ==================
   ```
   
   ```
   ==================
   WARNING: ThreadSanitizer: data race (pid=32645)
     Read of size 8 at 0x00000129fe00 by thread T2:
       #0 Thread::get_hrtime() 
/home/wkaras/REPOS/TS/iocore/eventsystem/I_Thread.h:188 
(traffic_server+0xaac48c)
       #1 EThread::schedule_every(Continuation*, long, int, void*) 
/home/wkaras/REPOS/TS/iocore/eventsystem/P_UnixEThread.h:95 
(traffic_server+0xab1c42)
       #2 initialize_thread_for_net(EThread*) 
/home/wkaras/REPOS/TS/iocore/net/UnixNet.cc:254 (traffic_server+0xc7f625)
       #3 invoke 
/home/wkaras/REPOS/TS/iocore/eventsystem/UnixEventProcessor.cc:134 
(traffic_server+0xcf52f6)
       #4 Continuation::handleEvent(int, void*) 
/home/wkaras/REPOS/TS/iocore/eventsystem/I_Continuation.h:227 
(traffic_server+0x711d65)
       #5 EventProcessor::initThreadState(EThread*) 
/home/wkaras/REPOS/TS/iocore/eventsystem/UnixEventProcessor.cc:464 
(traffic_server+0xcf6d0d)
       #6 EventProcessor::ThreadInit::init(int, Event*) 
/home/wkaras/REPOS/TS/iocore/eventsystem/I_EventProcessor.h:388 
(traffic_server+0xcf7a76)
       #7 Continuation::handleEvent(int, void*) 
/home/wkaras/REPOS/TS/iocore/eventsystem/I_Continuation.h:227 
(traffic_server+0x711d65)
       #8 EThread::execute() 
/home/wkaras/REPOS/TS/iocore/eventsystem/UnixEThread.cc:333 
(traffic_server+0xcf290b)
       #9 spawn_thread_internal 
/home/wkaras/REPOS/TS/iocore/eventsystem/Thread.cc:79 (traffic_server+0xcf0278)
   
     Previous write of size 8 at 0x00000129fe00 by thread T3 (mutexes: write 
M287807292786326448):
       #0 Thread::get_hrtime_updated() 
/home/wkaras/REPOS/TS/iocore/eventsystem/I_Thread.h:194 
(traffic_server+0xaac4ca)
       #1 EThread::execute_regular() 
/home/wkaras/REPOS/TS/iocore/eventsystem/UnixEThread.cc:274 
(traffic_server+0xcf2392)
       #2 EThread::execute() 
/home/wkaras/REPOS/TS/iocore/eventsystem/UnixEThread.cc:349 
(traffic_server+0xcf29cd)
       #3 spawn_thread_internal 
/home/wkaras/REPOS/TS/iocore/eventsystem/Thread.cc:79 (traffic_server+0xcf0278)
   
     Location is global 'Thread::cur_time' of size 8 at 0x00000129fe00 
(traffic_server+0x00000129fe00)
   
     Mutex M287807292786326448 is already destroyed.
   
     Thread T2 '[ET_NET 0]' (tid=32655, running) created by main thread at:
       #0 pthread_create <null> (libtsan.so.0+0x615d8)
       #1 ink_thread_create ../../include/tscore/ink_thread.h:137 
(traffic_server+0xcefc7b)
       #2 Thread::start(char const*, void*, unsigned long, std::function<void 
()> const&) /home/wkaras/REPOS/TS/iocore/eventsystem/Thread.cc:96 
(traffic_server+0xcf03a6)
       #3 EventProcessor::spawn_event_threads(int, int, unsigned long) 
/home/wkaras/REPOS/TS/iocore/eventsystem/UnixEventProcessor.cc:439 
(traffic_server+0xcf68c1)
       #4 EventProcessor::start(int, unsigned long) 
/home/wkaras/REPOS/TS/iocore/eventsystem/UnixEventProcessor.cc:502 
(traffic_server+0xcf6f6c)
       #5 main traffic_server/traffic_server.cc:2025 (traffic_server+0x77f23a)
   
     Thread T3 '[ET_NET 1]' (tid=32656, running) created by main thread at:
       #0 pthread_create <null> (libtsan.so.0+0x615d8)
       #1 ink_thread_create ../../include/tscore/ink_thread.h:137 
(traffic_server+0xcefc7b)
       #2 Thread::start(char const*, void*, unsigned long, std::function<void 
()> const&) /home/wkaras/REPOS/TS/iocore/eventsystem/Thread.cc:96 
(traffic_server+0xcf03a6)
       #3 EventProcessor::spawn_event_threads(int, int, unsigned long) 
/home/wkaras/REPOS/TS/iocore/eventsystem/UnixEventProcessor.cc:439 
(traffic_server+0xcf68c1)
       #4 EventProcessor::start(int, unsigned long) 
/home/wkaras/REPOS/TS/iocore/eventsystem/UnixEventProcessor.cc:502 
(traffic_server+0xcf6f6c)
       #5 main traffic_server/traffic_server.cc:2025 (traffic_server+0x77f23a)
   
   SUMMARY: ThreadSanitizer: data race 
/home/wkaras/REPOS/TS/iocore/eventsystem/I_Thread.h:188 in Thread::get_hrtime()
   ==================
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to