moonchen commented on PR #9177: URL: https://github.com/apache/trafficserver/pull/9177#issuecomment-1306457717
> I think this is a good find. But the OpenSSL docs isn't very specific on whether the first cert needs to be added using `SSL_CTX_use_certificate`. Since it says (https://www.openssl.org/docs/man1.1.1/man3/SSL_CTX_use_certificate.html) "The rest of the certificates needed to form the complete certificate chain can be specified using the `SSL_CTX_add_extra_chain_cert` function". Could you confirm that all certs can be added to the chain using `SSL_CTX_add_extra_chain_cert`, including the first one? The first cert is still added using `SSL_CTX_use_certificate` on line 828, so this only changes the loading of the second certificate and subsequent certs. Before this change, loading a certificate chain and a private key will cause OpenSSL to give an error that the cert and key don't match. I can confirm that loading the chain this way gets OpenSSL to pass the `SSL_CTX_check_private_key`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
