maskit commented on code in PR #9346:
URL: https://github.com/apache/trafficserver/pull/9346#discussion_r1099399316
##########
proxy/http3/Http3Session.cc:
##########
@@ -38,9 +38,8 @@ HQSession::HQSession(NetVConnection *vc) : ProxySession(vc)
HQSession::~HQSession()
{
- for (HQTransaction *t = this->_transaction_list.head; t; t =
static_cast<HQTransaction *>(t->link.next)) {
- delete t;
- }
+ // Transactions should be deleted first before HQSesson gets deleted.
+ ink_assert(this->_transaction_list.head);
Review Comment:
We originally had cleanup code here, but I realized that deleting a
transaction modifies the transaction list. I removed the cleanup code since it
was just a safety net.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
