bneradt commented on code in PR #9358:
URL: https://github.com/apache/trafficserver/pull/9358#discussion_r1103696487
##########
proxy/http/HttpTransact.cc:
##########
@@ -6366,8 +6367,16 @@ HttpTransact::is_request_valid(State *s, HTTPHdr
*incoming_request)
RequestError_t incoming_error;
URL *url = nullptr;
- // If we are blind tunneling the header is just a synthesized placeholder
anyway
+ // If we are blind tunneling the header is just a synthesized placeholder
anyway.
+ // But we do have to check that we are not tunneling to a dynamic port that
is
+ // not in the connect_ports list.
if (s->client_info.port_attribute == HttpProxyPort::TRANSPORT_BLIND_TUNNEL) {
+ if (!is_port_in_range(incoming_request->url_get()->port_get(),
s->http_config_param->connect_ports)) {
Review Comment:
We should also check `tunnel_port_is_dynamic` actually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
