zwoop commented on code in PR #9413: URL: https://github.com/apache/trafficserver/pull/9413#discussion_r1107802910
########## iocore/net/I_UDPPacket.h: ########## @@ -63,48 +63,9 @@ class UDPPacket int from_size; LINK(UDPPacket, link); -}; - -/** - Create a new packet to be sent over UDPConnection. This actually - copies data from a buffer. - - @param to address of where to send packet - @param when ink_hrtime relative to ink_get_hrtime_internal() - @param buf if !nullptr, then len bytes copied from buf and made into packet. - @param len # of bytes to copy from buf - */ Review Comment: Yeh, again my fault, and honestly I don't find those useful anyways. But yeh, we can ask Chris to restore them. One thing though, several of those "extern" declarations had no implementation anywhere, so they were there, documented, and not usable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
