maskit commented on code in PR #9424:
URL: https://github.com/apache/trafficserver/pull/9424#discussion_r1108800329
##########
iocore/net/I_UDPPacket.h:
##########
@@ -42,13 +43,47 @@
class UDPPacket
{
public:
- virtual ~UDPPacket() {}
- virtual void free(); // fast deallocate
- void setContinuation(Continuation *c);
- void setConnection(UDPConnection *c);
- UDPConnection *getConnection();
- IOBufferBlock *getIOBlockChain();
- int64_t getPktLength() const;
+ UDPPacket();
+ ~UDPPacket();
+ void free(); // fast deallocate
+
+ void
+ setContinuation(Continuation *c)
+ {
+ cont = c;
+ }
+
+ void
+ setConnection(UDPConnection *c)
Review Comment:
I'd rather have function definitions out of class definition for readability
especially if functions have multiple lines, although having those in a header
file is fine if those don't bring additional dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
