SolidWallOfCode commented on code in PR #9459:
URL: https://github.com/apache/trafficserver/pull/9459#discussion_r1117350487


##########
include/tscore/ink_file.h:
##########
@@ -46,7 +46,8 @@
 #endif
 
 // Darwin keeps statfs(2) in <sys/mount.h> ...
-#if HAVE_SYS_MOUNT_H
+// Its problematic if linux/mount.h is already included so check for that

Review Comment:
   Perhaps change this to use `__has_include`? E.g.
   ```
   #if __has_include("sys/mount.h")
   #  include "sys/mount.h"
   #elif __has_include("linux_mount.h")
   #  include "linux/mount.h"
   #endif
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to