cmcfarlen commented on code in PR #9459:
URL: https://github.com/apache/trafficserver/pull/9459#discussion_r1117363509
##########
CMakeLists.txt:
##########
@@ -28,8 +28,14 @@ project(ats)
enable_testing()
set(CMAKE_CXX_STANDARD 17)
+set(CMAKE_CXX_STANDARD_REQUIRED ON)
+set(CMAKE_CXX_EXTENSIONS OFF)
list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake")
+list(APPEND CMAKE_REQUIRED_DEFINITIONS -D_GNU_SOURCE)
Review Comment:
This was to get some symbols from sys/types.h iirc. I'm not sure why this
wasn't pre-defined? It might be better fixed another way eventually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
