maskit commented on code in PR #9432:
URL: https://github.com/apache/trafficserver/pull/9432#discussion_r1119515501


##########
plugins/experimental/webp_transform/ImageTransform.cc:
##########
@@ -183,7 +183,7 @@ class GlobalHookPlugin : public GlobalPlugin
 
     // If we might need to convert check to see if what the browser supports
     if (transaction_convert_to_webp == true || transaction_convert_to_jpeg == 
true) {
-      std::string accept  = 
transaction.getServerRequest().getHeaders().values("Accept");
+      std::string accept  = 
transaction.getClientRequest().getHeaders().values("Accept");
       bool webp_supported = accept.find("image/webp") != std::string::npos;

Review Comment:
   If something modifies Accept header, the something should be responsible for 
returning a content that the client accept.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to