ywkaras commented on PR #9424: URL: https://github.com/apache/trafficserver/pull/9424#issuecomment-1447524661
Here are the source files that reference `UDPPacketInternal`: ``` wkaras ~/REPOS/TS2 O$ grep -Fl UDPPacketInternal $(findsrc) ./include/tscore/UDP_stubs.h ./iocore/net/P_UDPPacket.h ./iocore/net/P_UDPNet.h ./iocore/net/QUICNet.cc ./iocore/net/P_QUICNet.h ./iocore/net/P_UnixUDPConnection.h ./iocore/net/QUICPacketHandler.cc ./iocore/net/UnixUDPNet.cc ./iocore/net/I_UDPConnection.h ./iocore/net/UnixUDPConnection.cc ./iocore/net/QUICPacketHandler_quiche.cc wkaras ~/REPOS/TS2 O$ ``` Here are the source files that reference `UDPPacket` but not `UDPPacketInternal`: ``` wkaras ~/REPOS/TS2 O$ grep -Fl UDPPacket $(findsrc) | while read F ; do if grep -F UDPPacketInternal $F > /dev/null ; then : ; else echo $F ; fi ; done ./include/ts/InkAPIPrivateIOCore.h ./iocore/net/I_UDPNet.h ./iocore/net/QUICNetVConnection.cc ./iocore/net/I_UDPPacket.h ./iocore/net/quic/QUICConnection.h ./iocore/net/quic/Mock.h ./iocore/net/quic/QUICPacketReceiveQueue.cc ./iocore/net/quic/QUICPacketReceiveQueue.h ./iocore/net/test_I_UDPNet.cc ./iocore/net/QUICNetVConnection_quiche.cc ./iocore/net/P_QUICPacketHandler_native.h ./iocore/net/P_QUICNetVConnection_native.h ./iocore/net/P_QUICNetVConnection_quiche.h ./iocore/net/P_QUICPacketHandler_quiche.h ./src/traffic_server/InkIOCoreAPI.cc wkaras ~/REPOS/TS2 O$ ``` So there is some scoping that is lost by combining the classes. Why is this scoping of no value, or what outweighs the value of it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
