masaori335 commented on PR #9394: URL: https://github.com/apache/trafficserver/pull/9394#issuecomment-1447683208
For the logic, having more complicated tests is better, but current tests have enough coverage to start testing this reader-writer lock widely. Let's have more eyeballs. For the benchmark, I noticed Catch2 Benchmark provides an option[*1] (`return` from the function) for the optimization and benchmark issue. I followed this way. Also, I checked with `objdump -d` and ran the benchmark on the lldb with "disassembly mode"[*2]. It has some instructions. [*1] https://github.com/catchorg/Catch2/blob/v2.13.8/docs/benchmarks.md#the-optimizer [*2] https://github.com/llvm/llvm-project/blob/main/lldb/examples/python/disassembly_mode.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
