mlibbey commented on code in PR #9431:
URL: https://github.com/apache/trafficserver/pull/9431#discussion_r1120543467
##########
src/tscore/unit_tests/test_ArgParser.cc:
##########
@@ -79,10 +79,10 @@ TEST_CASE("Parsing test", "[parse]")
parsed_data = parser.parse(argv2);
REQUIRE(parsed_data.get("init") == true);
REQUIRE(parsed_data.get("subinitopt") == true);
- REQUIRE(parsed_data.get("globaly") == true);
- REQUIRE(parsed_data.get("globaly").size() == 2);
- REQUIRE(parsed_data.get("globaly")[0] == "y1");
- REQUIRE(parsed_data.get("globaly")[1] == "y2");
+ REQUIRE(parsed_data.get("globally") == true);
+ REQUIRE(parsed_data.get("globally").size() == 2);
+ REQUIRE(parsed_data.get("globally")[0] == "y1");
+ REQUIRE(parsed_data.get("globally")[1] == "y2");
Review Comment:
globally means relating to the whole thing, and is in english dictionaries.
globaly isn't in english dictionaries -- what does it mean? relating to a
glob?
(or is your point that it needs fixing in more spots?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
