shukitchan commented on code in PR #9431:
URL: https://github.com/apache/trafficserver/pull/9431#discussion_r1120720455
##########
src/tscore/unit_tests/test_ArgParser.cc:
##########
@@ -79,10 +79,10 @@ TEST_CASE("Parsing test", "[parse]")
parsed_data = parser.parse(argv2);
REQUIRE(parsed_data.get("init") == true);
REQUIRE(parsed_data.get("subinitopt") == true);
- REQUIRE(parsed_data.get("globaly") == true);
- REQUIRE(parsed_data.get("globaly").size() == 2);
- REQUIRE(parsed_data.get("globaly")[0] == "y1");
- REQUIRE(parsed_data.get("globaly")[1] == "y2");
+ REQUIRE(parsed_data.get("globally") == true);
+ REQUIRE(parsed_data.get("globally").size() == 2);
+ REQUIRE(parsed_data.get("globally")[0] == "y1");
+ REQUIRE(parsed_data.get("globally")[1] == "y2");
Review Comment:
Yeah. This file is a test for the argument parser. So the test defines a few
string like "global x", "global y" and "global z" as tokens for the parser. So
it is not a spelling mistake for "globaly". Rather it is not referring to one
of the tokens to be found inside the string.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
