maskit commented on PR #9477: URL: https://github.com/apache/trafficserver/pull/9477#issuecomment-1450544749
Hmm, I like the idea but I'm not sure if that works for timeouts. It's kinda obvious that we cannot set 500 milli-bytes nor 8.3 bytes as a file/buffer size. Its minimum unit is obviously byte. On the other hand, 125 milliseconds can make sense for some timeout, but users don't know the actual internal precision unless the documentation says it. I found the setting currently takes millisecond. I guess I used the unit which the spec use without thinking about it much. Let's keep this PR simple and think about the unit specifier at somewhere else. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
