bneradt commented on code in PR #9366:
URL: https://github.com/apache/trafficserver/pull/9366#discussion_r1143534189
##########
proxy/http2/Http2ConnectionState.cc:
##########
@@ -2272,51 +2635,52 @@ Http2ConnectionState::_has_dynamic_stream_window() const
}
ssize_t
-Http2ConnectionState::get_peer_rwnd_in() const
+Http2ConnectionState::get_peer_rwnd() const
{
- return this->_peer_rwnd_in;
+ return this->_peer_rwnd;
}
Http2ErrorCode
-Http2ConnectionState::increment_peer_rwnd_in(size_t amount)
+Http2ConnectionState::increment_peer_rwnd(size_t amount)
{
- this->_peer_rwnd_in += amount;
+ this->_peer_rwnd += amount;
this->_recent_rwnd_increment[this->_recent_rwnd_increment_index] = amount;
++this->_recent_rwnd_increment_index;
this->_recent_rwnd_increment_index %= this->_recent_rwnd_increment.size();
- double sum = std::accumulate(this->_recent_rwnd_increment.begin(),
this->_recent_rwnd_increment.end(), 0.0);
- double avg = sum / this->_recent_rwnd_increment.size();
- if (avg < Http2::min_avg_window_update) {
- HTTP2_INCREMENT_THREAD_DYN_STAT(HTTP2_STAT_INSUFFICIENT_AVG_WINDOW_UPDATE,
this_ethread());
- return Http2ErrorCode::HTTP2_ERROR_ENHANCE_YOUR_CALM;
- }
+ // SKH Causing problems with gRPC processing. Python example resulted in
amount 8
+ // double sum = std::accumulate(this->_recent_rwnd_increment.begin(),
this->_recent_rwnd_increment.end(), 0.0);
+ // double avg = sum / this->_recent_rwnd_increment.size();
+ // if (avg < Http2::min_avg_window_update) {
+ //
HTTP2_INCREMENT_THREAD_DYN_STAT(HTTP2_STAT_INSUFFICIENT_AVG_WINDOW_UPDATE,
this_ethread());
Review Comment:
Makes sense. I added this back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
