bneradt commented on code in PR #9366:
URL: https://github.com/apache/trafficserver/pull/9366#discussion_r1145380037
##########
proxy/http2/unit_tests/test_HTTP2.cc:
##########
@@ -107,8 +107,8 @@ TEST_CASE("Convert HTTPHdr", "[HTTP2]")
// check
CHECK_THAT(buf, Catch::StartsWith("GET
https://trafficserver.apache.org/index.html HTTP/1.1\r\n"
- "Host: trafficserver.apache.org\r\n"
"User-Agent: foobar\r\n"
+ "Host: trafficserver.apache.org\r\n"
Review Comment:
It does add the pseudo header fields at the beginning, but it calls the same
`field_attach` mechanism, which appends. It can do so because it is always on a
new HdrHeap, it seems to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
