bneradt commented on code in PR #9606:
URL: https://github.com/apache/trafficserver/pull/9606#discussion_r1165727141


##########
tools/build_h3_tools.sh:
##########
@@ -169,3 +169,38 @@ autoreconf -i
   LDFLAGS="${LDFLAGS}"
 ${MAKE} -j $(nproc)
 sudo ${MAKE} install
+
+# boringssl
+echo "Building boringssl..."
+
+# We need this go version.
+GO_BASE_PATH=/usr/local
+if [ ! -d ${GO_BASE_PATH} ]; then
+  sudo mkdir ${GO_BASE_PATH}
+fi
+
+wget https://go.dev/dl/go1.20.1.linux-amd64.tar.gz
+sudo rm -rf ${GO_BASE_PATH}/go && sudo tar -C ${GO_BASE_PATH} -xf 
go1.20.1.linux-amd64.tar.gz
+rm go1.20.1.linux-amd64.tar.gz

Review Comment:
   Quite a few of us build in docker containers on m1 macs. Let's conditionally 
use `arm64` based upon `uname -m`.
   
   I think this can change to:
   
   ```sh
   if [ `uname -m` = "arm64" ]; then
       ARCH="arm64"
   else
       ARCH="amd64"
   fi
   
   wget https://go.dev/dl/go1.20.1.linux-${ARCH}.tar.gz
   sudo rm -rf ${GO_BASE_PATH}/go && sudo tar -C ${GO_BASE_PATH} -xf 
go1.20.1.linux-${ARCH}.tar.gz
   rm go1.20.1.linux-${ARCH}.tar.gz
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to