cmcfarlen commented on code in PR #9594:
URL: https://github.com/apache/trafficserver/pull/9594#discussion_r1166814349
##########
doc/admin-guide/files/sni.yaml.en.rst:
##########
@@ -176,6 +176,8 @@ tunnel_route Inbound Destination as an FQDN
and port, separated b
Protocol <proxy-protocol>` for more
information on Proxy Protocol and how it is
configured for |TS|.
+ Note that the match group number can be
used in combination with the ``{inbound_local_port}`` and
``{proxy_protocol_port}`` literal strings.
+
Review Comment:
The code and this comment don't seem to agree. The code is such that only
one of `{inbound_local_port}` or `{proxy_protocol_port}` will be used with
`{inbound_local_port}` taking precedence. If both are specified, the
`{proxy_protocol_port}` function is not run at all. I recommend address this
in the documentation and better handle the case where both strings are present
(warning or error).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
