SolidWallOfCode opened a new pull request, #9618:
URL: https://github.com/apache/trafficserver/pull/9618
This replaces the hand rolled substitution code for configuring a tunnel
destination with `BufferWriter` formatting.
* This results in much less code.
* The code is more general - any or all of the substitutions can be used in
a single configuration.
* Additional substitutions can be added with just a few lines of very simple
code.
* Better performances - in most cases no allocation is done to generate the
rewritten destination string.
* Many elements are removed, because there is no special handling for each
supported substitution.
* BWF optimizes for the literal / no substitutions case without requiring
the client to check.
Compatibility change - capture groups must be referred to use numeric
arguments, e.g. `{1}` and not `$1`. This makes more than ten groups trivial to
support with less in line ambiguity (e.g. "{1}2" vs. "$12").
I also moved the embarrassingly large header inline methods to the source
file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
