cmcfarlen commented on code in PR #9606:
URL: https://github.com/apache/trafficserver/pull/9606#discussion_r1172839280
##########
tools/build_h3_tools.sh:
##########
@@ -169,3 +169,38 @@ autoreconf -i
LDFLAGS="${LDFLAGS}"
${MAKE} -j $(nproc)
sudo ${MAKE} install
+
+# boringssl
+echo "Building boringssl..."
+
+# We need this go version.
+GO_BASE_PATH=/usr/local
Review Comment:
For docker /usr/local is fine, but this script might be run on any host as
well. If it's in /usr/local it could preempt an existing golang install and
leave the user in a state of astonishment. imo, if this script is going to
always install this version of go it should be out of the way of any possible
system installations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
