bneradt commented on code in PR #9617:
URL: https://github.com/apache/trafficserver/pull/9617#discussion_r1175541819
##########
proxy/http/Makefile.am:
##########
@@ -129,22 +129,31 @@ test_HttpTransact_CPPFLAGS = \
-I$(abs_top_srcdir)/tests/include
if OS_LINUX
-test_HttpTransact_LDFLAGS = $(AM_LDFLAGS)\
- -Wl,--unresolved-symbols=ignore-all
+test_HttpTransact_LDFLAGS = $(AM_LDFLAGS)
else
test_HttpTransact_LDFLAGS = $(AM_LDFLAGS)\
-Wl,-undefined -Wl,suppress -Wl,-flat_namespace -Wl,-dead_strip
endif
-test_HttpTransact_LDADD = \
+test_HttpTransact_LDADD = \
+ $(top_builddir)/proxy/http/libhttp.a \
+ $(top_builddir)/proxy/http/remap/libhttp_remap.a \
+ $(top_builddir)/proxy/logging/liblogging.a \
+ $(top_builddir)/proxy/hdrs/libhdrs.a \
+ $(top_builddir)/iocore/utils/libinkutils.a \
+ $(top_builddir)/iocore/hostdb/libinkhostdb.a \
+ $(top_builddir)/iocore/dns/libinkdns.a \
+ $(top_builddir)/iocore/cache/libinkcache.a \
+ $(top_builddir)/lib/fastlz/libfastlz.a \
+ $(top_builddir)/iocore/aio/libinkaio.a \
$(top_builddir)/src/tscore/libtscore.la \
+ $(top_builddir)/src/tscpp/util/libtscpputil.la \
+ $(top_builddir)/proxy/libproxy.a \
+ $(top_builddir)/iocore/net/libinknet.a \
$(top_builddir)/src/records/librecords_p.a \
- $(top_builddir)/proxy/ProxySession.o \
- $(top_builddir)/proxy/http/HttpTransact.o \
- $(top_builddir)/proxy/http/HttpTransactHeaders.o \
- $(top_builddir)/proxy/hdrs/libhdrs.a \
$(top_builddir)/iocore/eventsystem/libinkevent.a \
Review Comment:
Looks good. Thanks @lzx404243 .
It wasn't sorted before, but while we're at it can you please sort this .a
list?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
