maskit commented on code in PR #9624:
URL: https://github.com/apache/trafficserver/pull/9624#discussion_r1180663052
##########
iocore/net/OCSPStapling.cc:
##########
@@ -46,13 +40,217 @@
extern ClassAllocator<FetchSM> FetchSMAllocator;
Review Comment:
```
CXX OCSPStapling.o
OCSPStapling.cc:230:1: error: no template named 'StackTraits'; did you mean
'::bssl::internal::StackTraits'?
DEFINE_STACK_OF(TS_OCSP_ONEREQ)
^
/Users/mkitajo/opt/boringssl/include/openssl/stack.h:100:31: note: expanded
from macro 'DEFINE_STACK_OF'
#define DEFINE_STACK_OF(type) DEFINE_NAMED_STACK_OF(type, type)
^
/Users/mkitajo/opt/boringssl/include/openssl/stack.h:94:3: note: expanded
from macro 'DEFINE_NAMED_STACK_OF'
BORINGSSL_DEFINE_STACK_TRAITS(name, type, false)
^
/Users/mkitajo/opt/boringssl/include/openssl/stack.h:357:10: note: expanded
from macro 'BORINGSSL_DEFINE_STACK_TRAITS'
struct StackTraits<STACK_OF(name)> { \
^
/Users/mkitajo/opt/boringssl/include/openssl/stack.h:347:8: note:
'::bssl::internal::StackTraits' declared here
struct StackTraits {};
^
OCSPStapling.cc:230:1: error: class template specialization of 'StackTraits'
not in a namespace enclosing 'internal'
DEFINE_STACK_OF(TS_OCSP_ONEREQ)
^
/Users/mkitajo/opt/boringssl/include/openssl/stack.h:100:31: note: expanded
from macro 'DEFINE_STACK_OF'
#define DEFINE_STACK_OF(type) DEFINE_NAMED_STACK_OF(type, type)
^
/Users/mkitajo/opt/boringssl/include/openssl/stack.h:94:3: note: expanded
from macro 'DEFINE_NAMED_STACK_OF'
BORINGSSL_DEFINE_STACK_TRAITS(name, type, false)
^
/Users/mkitajo/opt/boringssl/include/openssl/stack.h:357:10: note: expanded
from macro 'BORINGSSL_DEFINE_STACK_TRAITS'
struct StackTraits<STACK_OF(name)> { \
^
blah blah blah
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
