cmcfarlen commented on code in PR #9657:
URL: https://github.com/apache/trafficserver/pull/9657#discussion_r1181684727
##########
iocore/cache/RamCacheLRU.cc:
##########
@@ -58,6 +58,12 @@ struct RamCacheLRU : public RamCache {
RamCacheLRUEntry *remove(RamCacheLRUEntry *e);
};
+#ifdef DEBUG
+
+static DbgCtl dbg_ctl_ram_cache{"ram_cache"};
Review Comment:
anon namespace here too?
##########
include/tscore/Trie.h:
##########
@@ -30,9 +30,16 @@
#include "tscore/List.h"
#include "tscore/Diags.h"
+class TrieImpl
+{
+protected:
+ inline static DbgCtl dbg_ctl_insert{"Trie::Insert"};
+ inline static DbgCtl dbg_ctl_search{"Trie::Search"};
+};
Review Comment:
Is this so these only get constructed if a Trie does?
##########
iocore/cache/P_CacheInternal.h:
##########
@@ -49,9 +49,9 @@ struct EvacuationBlock;
#endif
#ifdef DEBUG
-#define DDebug(tag, fmt, ...) Debug(tag, fmt, ##__VA_ARGS__)
+#define DDbg(dbg_ctl, fmt, ...) Dbg(dbg_ctl, fmt, ##__VA_ARGS__)
Review Comment:
These seem pretty useful generally. Should we move the up next to Dbg?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
