maskit commented on PR #9647:
URL: https://github.com/apache/trafficserver/pull/9647#issuecomment-1532304003
That doesn't look like an incompatibility from the test. The diff is just 3
lines.
```diff
$ git diff 7dbb6cb1881aa344edb1ab59dcbe3342171ea0a7^..master
tests/gold_tests/tls/tls_keepalive.test.py
diff --git a/tests/gold_tests/tls/tls_keepalive.test.py
b/tests/gold_tests/tls/tls_keepalive.test.py
index ac5142478..6694aacba 100644
--- a/tests/gold_tests/tls/tls_keepalive.test.py
+++ b/tests/gold_tests/tls/tls_keepalive.test.py
@@ -27,7 +27,7 @@ Test.SkipUnless(
Condition.HasCurlFeature('http2')
)
-ts = Test.MakeATSProcess("ts", select_ports=True, enable_tls=True)
+ts = Test.MakeATSProcess("ts", enable_tls=True)
server = Test.MakeOriginServer("server")
request_header = {"headers": "GET / HTTP/1.1\r\nHost:
www.example.com\r\n\r\n", "timestamp": "1469733493.993", "body": ""}
# desired response form the origin server
@@ -40,7 +40,7 @@ ts.addSSLfile("ssl/server.key")
ts.Disk.records_config.update({
'proxy.config.ssl.server.cert.path': '{0}'.format(ts.Variables.SSLDir),
'proxy.config.ssl.server.private_key.path':
'{0}'.format(ts.Variables.SSLDir),
- 'proxy.config.ssl.TLSv1_3': 0,
+ 'proxy.config.ssl.TLSv1_3.enabled': 0,
'proxy.config.exec_thread.autoconfig.scale': 1.0,
'proxy.config.log.max_secs_per_buffer': 1
})
@@ -66,7 +66,7 @@ logging:
'''.split("\n")
)
-Test.PrepareTestPlugin(os.path.join(Test.Variables.AtsTestPluginsDir,
'ssl_hook_test.so'), ts, '-preaccept=1')
+Test.PrepareTestPlugin(os.path.join(Test.Variables.AtsTestPluginsDir,
'ssl_secret_load_test.so'), ts)
tr = Test.AddTestRun("Test two HTTP/1.1 requests over one TLS connection")
tr.Processes.Default.StartBefore(server)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
