bneradt commented on code in PR #9675:
URL: https://github.com/apache/trafficserver/pull/9675#discussion_r1183174932
##########
proxy/ControlBase.cc:
##########
@@ -428,9 +428,10 @@ TextMod::set(const char *value)
}
struct MultiTextMod : public ControlBase::Modifier {
- std::vector<swoc::MemSpan<char>> text_vec;
+ std::string _s; ///< Storage for all strings.
Review Comment:
Probably good to make _s private.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
