jpeach commented on code in PR #9674:
URL: https://github.com/apache/trafficserver/pull/9674#discussion_r1183269929
##########
iocore/net/OCSPStapling.cc:
##########
@@ -957,8 +957,10 @@ stapling_check_response(certinfo *cinf, TS_OCSP_RESPONSE
*rsp)
if (!TS_OCSP_resp_find_status(bs, cinf->cid, &status, &reason, &rev,
&thisupd, &nextupd)) {
// If ID not present just pass it back to client
Error("stapling_check_response: certificate ID not present in response for
%s", cinf->certname);
- } else {
- TS_OCSP_check_validity(thisupd, nextupd, 300, -1);
+ }
+ if (!TS_OCSP_check_validity(thisupd, nextupd, 300, -1)) {
Review Comment:
If you failed to get the status, is it still OK to check the validity? I'm
guessing that the extra checks only apply for status TS_OCSP_CERTSTATUS_GOOD,
since otherwise, the response is already bad?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
