brbzull0 commented on code in PR #9670:
URL: https://github.com/apache/trafficserver/pull/9670#discussion_r1183481212
##########
configure.ac:
##########
@@ -1451,19 +1427,19 @@ TS_CHECK_BROTLI
TS_CHECK_LUAJIT
# Check for optional quiche library
+enable_quic=no
TS_CHECK_QUICHE
if test "${has_quiche}" = "1"; then
if test "$openssl_is_boringssl" = "1" ; then
enable_quic=yes
-## Doing these again for Quiche
-AM_CONDITIONAL([ENABLE_QUIC], [test "x$enable_quic" = "xyes"])
-TS_ARG_ENABLE_VAR([use], [quic])
-AC_SUBST(use_quic)
-AC_SUBST(has_quiche)
else
AC_MSG_ERROR([Use of BoringSSL is required if Quiche is used.])
fi
fi
+TS_ARG_ENABLE_VAR([use], [quic])
+AC_SUBST(use_quic)
Review Comment:
`use_quic` or `quiche` both imply the same things from now on, so I wonder
if we should keep two separate variables for the QUIC implementation.
No need to change this now anyway, but we can agree and add task for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
