maskit commented on code in PR #9674:
URL: https://github.com/apache/trafficserver/pull/9674#discussion_r1183861111


##########
iocore/net/OCSPStapling.cc:
##########
@@ -957,8 +957,10 @@ stapling_check_response(certinfo *cinf, TS_OCSP_RESPONSE 
*rsp)
   if (!TS_OCSP_resp_find_status(bs, cinf->cid, &status, &reason, &rev, 
&thisupd, &nextupd)) {
     // If ID not present just pass it back to client
     Error("stapling_check_response: certificate ID not present in response for 
%s", cinf->certname);
-  } else {
-    TS_OCSP_check_validity(thisupd, nextupd, 300, -1);
+  }

Review Comment:
   I'm not sure if we should cache it, but I think we should just tell the 
truth to the client to give the information that the response is invalid.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to