brbzull0 commented on PR #9679: URL: https://github.com/apache/trafficserver/pull/9679#issuecomment-1536142979
> Not a big deal, but with this change I see this (look at the last part). > > > /bin/sh ../libtool --tag=CXX --mode=link ccache c++ -std=c++17 -g -pipe -Wall -Qunused-arguments -Wextra -Wno-unused-parameter -Werror -Wno-invalid-offsetof -fno-omit-frame-pointer -fsanitize=address -R/Users/mkitajo/opt/boringssl/lib -R/opt/homebrew/Cellar/pcre/8.45/lib -R/Users/mkitajo/opt/quiche/lib -L/Users/mkitajo/src/github.com/trafficserver/lib/swoc -L/Users/mkitajo/opt/boringssl/lib -L/opt/homebrew/Cellar/pcre/8.45/lib -L/Users/mkitajo/opt/quiche/lib -o traffic_cache_tool/traffic_cache_tool traffic_cache_tool/traffic_cache_tool-CacheDefs.o traffic_cache_tool/traffic_cache_tool-CacheTool.o traffic_cache_tool/traffic_cache_tool-CacheScan.o ../src/tscore/.libs/ArgParser.o ../src/tscore/.libs/ink_assert.o ../src/tscore/.libs/ink_error.o ../src/tscore/.libs/ink_file.o ../src/tscore/.libs/ink_memory.o ../src/tscore/.libs/ink_mutex.o ../src/tscore/.libs/ink_string.o ../src/tscore/.libs/BufferWriterFormat.o ../src/tscore/.libs/InkErrno.o ../src/tscore/.libs/Errata.o ../src /tscpp/util/.libs/TextView.o ../src/tscore/.libs/Regex.o ../src/tscore/.libs/CryptoHash.o ../src/tscore/.libs/MMH.o ../src/tscore/.libs/Version.o ../src/tscore/.libs/Regression.o ../src/tscore/.libs/ink_args.o ../src/tscore/.libs/ParseRules.o ../src/tscore/.libs/SourceLocation.o -ltsswoc -lssl -lcrypto -lpcre -lquiche -lssl -lcrypto I fixed this. I was wrong adding the flags to `LIBS` which will be used everywhere. Now should be fine. [Docs](https://www.gnu.org/software/autoconf/manual/autoconf-2.67/html_node/Libraries.html) always help :P ``` AC_CHECK_LIB (library, function, [action-if-found], [action-if-not-found], [other-libraries]) ... The other-libraries argument should be limited to cases where it is desirable to test for one library in the presence of another that is not already in LIBS. ``` Better not pullulate the `LIBS` as we also have `QUICHE_LIB` and `OPENSSL_LIBS` for this needs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
