ywkaras commented on code in PR #9672:
URL: https://github.com/apache/trafficserver/pull/9672#discussion_r1188090274
##########
iocore/net/OCSPStapling.cc:
##########
@@ -1016,13 +1028,21 @@ query_responder(const char *uri, const char
*user_agent, TS_OCSP_REQUEST *req, i
}
// Send request
- eventProcessor.schedule_imm(&httpreq, ET_NET);
+ Event *e = eventProcessor.schedule_imm(&httpreq, ET_NET);
// Wait until the request completes
do {
ink_hrtime_sleep(HRTIME_MSECONDS(1));
} while (!httpreq.is_done() && (Thread::get_hrtime() < end));
+ if (!httpreq.is_done()) {
+ Error("OCSP request was timed out; uri=%s", uri);
+ if (!httpreq.is_initiated()) {
+ Debug("ssl_ocsp", "Request is not initiated yet. Cancelling the event.");
+ e->cancel(&httpreq);
+ }
+ }
Review Comment:
Add a `}' to close the block and release the mutex.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
