jpeach commented on code in PR #9757:
URL: https://github.com/apache/trafficserver/pull/9757#discussion_r1212434672
##########
tools/clang-format.sh:
##########
@@ -46,13 +46,13 @@ function main() {
CURL=${CURL:-curl}
# Default to sha256sum, but honor the env variable just in case
- if [ $(which sha256sum) ] ; then
+ if [ -n "$(which sha256sum)" ] ; then
SHASUM=${SHASUM:-sha256sum}
else
SHASUM=${SHASUM:-shasum -a 256}
fi
- ARCHIVE=$ROOT/$(basename ${URL})
+ ARCHIVE="$ROOT/$(basename "${URL}")"
Review Comment:
Yep, because the inner quotes are in a subshell.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
