JosiahWI commented on code in PR #9842:
URL: https://github.com/apache/trafficserver/pull/9842#discussion_r1229836949
##########
CMakeLists.txt:
##########
@@ -88,25 +88,36 @@ CHECK_INCLUDE_FILE(arpa/nameser_compat.h
HAVE_ARPA_NAMESER_COMPAT_H)
CHECK_INCLUDE_FILE(siginfo.h HAVE_SIGINFO_H)
# Find libraries
-find_package(TSMallocReplacement QUIET MODULE)
-if(TSMallocReplacement_FOUND)
- link_libraries(ts::TSMallocReplacement)
-endif()
find_package(brotli)
if(brotli_FOUND)
set(HAVE_BROTLI_ENCODE_H TRUE)
endif()
+
find_package(hwloc)
if(hwloc_FOUND)
set(TS_USE_HWLOC TRUE)
endif()
+
find_package(LibLZMA)
if(LibLZMA_FOUND)
set(HAVE_LZMA_H TRUE)
endif()
+
find_package(PCRE)
+
include(FindOpenSSL)
find_package(OpenSSL)
+
+find_package(profiler)
+if(profiler_FOUND)
+ set(TS_HAS_PROFILER TRUE)
+endif()
Review Comment:
Maybe `ENABLE_PROFILER` would be better? The autotools build uses
`--enable-xxx` for enabling/disabling features, and I think this shows the
intent well. Note that the autotools build has no way to explicitly disable the
profiler that I could find.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
