jpeach commented on code in PR #9825:
URL: https://github.com/apache/trafficserver/pull/9825#discussion_r1230315803
##########
iocore/net/UnixNetProcessor.cc:
##########
@@ -56,34 +68,21 @@ NetProcessor::AcceptOptions::reset()
return *this;
}
-int net_connection_number = 1;
-
-unsigned int
-net_next_connection_number()
-{
- unsigned int res = 0;
- do {
- res = static_cast<unsigned
int>(ink_atomic_increment(&net_connection_number, 1));
- } while (!res);
- return res;
-}
-
Action *
-NetProcessor::accept(Continuation *cont, AcceptOptions const &opt)
+UnixNetProcessor::accept(Continuation *cont, AcceptOptions const &opt)
{
Debug("iocore_net_processor", "NetProcessor::accept - port %d,recv_bufsize
%d, send_bufsize %d, sockopt 0x%0x", opt.local_port,
opt.recv_bufsize, opt.send_bufsize, opt.sockopt_flags);
- return ((UnixNetProcessor *)this)->accept_internal(cont, NO_FD, opt);
+ return this->accept_internal(cont, NO_FD, opt);
Review Comment:
It makes me sad to do that, since `this->` improves readability so much, but
I agree with you that it is consistent to remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
