SolidWallOfCode commented on code in PR #9845: URL: https://github.com/apache/trafficserver/pull/9845#discussion_r1233074646
########## proxy/http/HttpSM.h: ########## @@ -519,6 +522,18 @@ class HttpSM : public Continuation, public PluginUserArgs<TS_USER_ARGS_TXN> /// Update the milestones to track time spent in the plugin API. void milestone_update_api_time(); + sockaddr * + get_server_ip() const Review Comment: There are two IP addresses associated with the server, the method name should indicate which one. The standard terms are "local" (address used on the ATS end of the socket) and "remote" (address used on the non-ATS end of the socket). This should probably be `get_server_remote_addr`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
