[GitHub] [trafficserver] bneradt commented on a diff in pull request #9878: libswoc: Update Errata use in cache tool.

Wed, 21 Jun 2023 11:37:19 -0700 


bneradt commented on code in PR #9878:
URL: https://github.com/apache/trafficserver/pull/9878#discussion_r1237426931


##########
src/traffic_cache_tool/CacheTool.cc:
##########
@@ -1349,7 +1349,7 @@ Scan_Cache(swoc::file::path const &regex_path)
   Cache cache;
   std::vector<std::thread> threadPool;
   if ((err = cache.loadSpan(SpanFile))) {
-    if (err.size()) {
+    if (err.length()) {

Review Comment:
   Why a length check rather than `if (!err.is_ok()) {`



##########
src/traffic_cache_tool/CacheTool.cc:
##########
@@ -1424,7 +1424,7 @@ main(int argc, const char *argv[])
     arguments.invoke();
   }
 
-  if (err.size()) {
+  if (err.length()) {

Review Comment:
   Why a length check rather than if (!err.is_ok()) {



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to