JosiahWI commented on code in PR #9924: URL: https://github.com/apache/trafficserver/pull/9924#discussion_r1245413731
########## src/tscore/CMakeLists.txt: ########## @@ -103,6 +102,14 @@ add_library(tscore SHARED ) add_library(ts::tscore ALIAS tscore) +if(OPENSSL_IS_BORINGSSL) + target_sources(tscore PUBLIC HKDF_boringssl.cc) +elseif(OPENSSL_IS_OPENSSL3) + target_sources(tscore PUBLIC HKDF_openssl3.cc) +else() + target_sources(tscore PUBLIC HKDF_openssl.cc) Review Comment: We do. I've been fixing a few here and there, but most of it will probably have to be part of the general cleanup. Regardless, we should make sure that new ones are correct. Part of the general problem there is that the cyclic dependencies result in usage requirements being weird. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
