masaori335 commented on code in PR #9403:
URL: https://github.com/apache/trafficserver/pull/9403#discussion_r1246121462
##########
iocore/eventsystem/I_VConnection.h:
##########
@@ -362,7 +362,13 @@ class VConnection : public Continuation
return false;
}
-public:
+ // This function should be called when the VConnection is a tunnel endpoint.
By default, a VConnection does not care if it
+ // is a tunnel endpoint.
+ virtual void
+ mark_as_tunnel_endpoint()
Review Comment:
This one?
```
HttpSM::setup_blind_tunnel(bool send_response_hdr, IOBufferReader *initial) {
...
ua_entry->vc->mark_as_tunnel_endpoint();
server_entry->vc->mark_as_tunnel_endpoint();
```
Can we use `ua_txn->get_netvc()` and `server_txn->get_netvc()` instead of
`ua_entry->vc` and `server_entry->vc` here? If possible, I prefer
`NetVConnection` to have this virtual function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
